Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
動作確認済みです
VP9
から未指定に変更するVP9
が利用されるため機能影響はないOPUS
から未指定に変更するOPUS
が利用されるため機能影響はないThis pull request includes changes to the
Sora
library to modify the default values for video and audio codec types. The most important changes include updating the default values forVideoCodecType
andAudioCodecType
to be unspecified, and adjusting theConnect
method to handle these unspecified values properly.Changes to default codec types:
Sora/Sora.cs
: Changed the default value ofVideoCodecType
fromVP9
to unspecified (VideoCodecType?
).Sora/Sora.cs
: Changed the default value ofAudioCodecType
fromOPUS
to unspecified (AudioCodecType?
).Adjustments in the
Connect
method:Sora/Sora.cs
: Modified theConnect
method to handle unspecifiedVideoCodecType
by settingcc.video_codec_type
to an empty string ifconfig.VideoCodecType
is null.Sora/Sora.cs
: Modified theConnect
method to handle unspecifiedAudioCodecType
by settingcc.audio_codec_type
to an empty string ifconfig.AudioCodecType
is null.Documentation updates:
CHANGES.md
: Documented the changes to the default values forVideoCodecType
andAudioCodecType
.