Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRTCConfiguration に degradationPreference を追加する #189

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

enm10k
Copy link
Contributor

@enm10k enm10k commented Feb 20, 2024

変更内容

  • WebRTCConfiguration に degradationPreference を追加しました
  • 自動ビルドでのチェックが失敗したため、解消するために SwiftFormat/CLI のバージョンの更新 & .swiftformat の修正を行いました

@enm10k enm10k requested review from torikizi and miosakuma February 20, 2024 08:31
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ソースコメントについて気になったところだけコメントしました。

CHANGES.md Outdated Show resolved Hide resolved
Sora/WebRTCConfigration.swift Outdated Show resolved Hide resolved
Sora/WebRTCConfigration.swift Outdated Show resolved Hide resolved
Sora/WebRTCConfigration.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます。その後の拡張も考えられていてとてもいいと思いました。

@enm10k
Copy link
Contributor Author

enm10k commented Feb 26, 2024

レビューありがとうございます
マージします

@enm10k enm10k merged commit a1310d6 into develop Feb 26, 2024
2 checks passed
@enm10k enm10k deleted the feature/sender-degradation-preference branch February 26, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants