-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
リリースに sumomo バイナリを含めるようにする #158
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a8cea51
リリースに sumomo バイナリを含めるようにする
torikizi ba26d43
CHANGES を更新
torikizi ca6651e
sumomo だけを抜き出してアーカイブにする処理を見直し
torikizi 825b725
サブシェルを使わず一つずつ実行する
torikizi 6ea4e03
examples のビルドとリリースを SDK と分ける
torikizi 79d0085
CHANGES を更新
torikizi 9edd9c5
変更履歴を修正
torikizi 89d6227
build.yml の修正を見直し
torikizi 22db937
Ubuntu24.04 共通パッケージなので runs-on を指定する
torikizi 0d6bb67
matrix の定義を使用できていない箇所が残っていた
torikizi 3bee9ea
コメント追加
torikizi 89d511a
通知の見直し
torikizi df076ba
コメント修正
torikizi b33addf
SDK の examples ビルドを戻す
torikizi 97a4d38
CHANGES を修正
torikizi f87a35d
Xcode の指定を外す
torikizi b66298f
Xcode のバージョン指定を外す
torikizi 74f312c
Ubuntu の examples のビルドを修正
torikizi 7b5afd5
Merge branch 'develop' into feature/add-sumomo-release-build-binary
torikizi d724f90
コメントを少し見直し
torikizi 6c5f641
不要なコメントを削除
voluntas 46e80f9
コメントと変更履歴を整理
voluntas 5c19bd6
インデントがおかしいのを修正する
voluntas 38fc98c
archive で統一する
voluntas 34de507
name 修正
voluntas 921a800
strategy を上にする
voluntas 875d1cb
strategy を上に持ってくる
voluntas b2687ce
不要なコメント削除
voluntas 83a4559
コスメ
voluntas 378ad70
Ubuntu は matrix.name まで指定が必要
torikizi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples のビルドをわけました。 SDK のビルドの中では行わないようにします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example 自体のビルドは、ビルドが通ることを確認するためにも必要です。
リリース時にしかビルドしないとリリース時に初めてビルドエラーに気が付くみたいなことになるし、そもそも今はリリース時に sumomo しかビルドしてないから、ほかのサンプルのビルドが通ることを担保できなくなります。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご指摘のとおりです。
SDK ビルド時の examples のビルドはこれまで通り実施するように戻します。