remove windows-argv-parser package and related code (#1156)

shiftkey · Nov 8, 2024 · 55580e6 · 55580e6
1 parent 21f4f1b
commit 55580e6
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/app/package.json b/app/package.json
@@ -66,7 +66,6 @@
     "tslib": "^2.0.0",
     "untildify": "^3.0.2",
     "uuid": "^3.0.1",
-    "windows-argv-parser": "file:../vendor/windows-argv-parser",
     "winston": "^3.6.0"
   },
   "devDependencies": {

diff --git a/app/src/lib/custom-integration.ts b/app/src/lib/custom-integration.ts
@@ -1,5 +1,4 @@
 import { ChildProcess, SpawnOptions, spawn } from 'child_process'
-import { parseCommandLineArgv } from 'windows-argv-parser'
 import stringArgv from 'string-argv'
 import { promisify } from 'util'
 import { exec } from 'child_process'
@@ -29,7 +28,7 @@ export interface ICustomIntegration {
 export function parseCustomIntegrationArguments(
   args: string
 ): ReadonlyArray<string> {
-  return __WIN32__ ? parseCommandLineArgv(args) : stringArgv(args)
+  return stringArgv(args)
 }
 
 // Function to retrieve, on macOS, the bundleId of an app given its path

diff --git a/app/yarn.lock b/app/yarn.lock
@@ -821,11 +821,6 @@ node-addon-api@^5.0.0:
   resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-5.0.0.tgz#7d7e6f9ef89043befdb20c1989c905ebde18c501"
   integrity sha512-CvkDw2OEnme7ybCykJpVcKH+uAOLV2qLqiyla128dN9TkEWfrYmxG6C2boDe5KcNQqZF3orkqzGgOMvZ/JNekA==
 
-node-addon-api@^7.0.0:
-  version "7.1.1"
-  resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-7.1.1.tgz#1aba6693b0f255258a049d621329329322aad558"
-  integrity sha512-5m3bsyrjFWE1xf7nz7YXdN4udnVtXK6/Yfgn5qnahL6bCkf2yKt4k3nuTKAtT4r3IG8JNR2ncsIMdZuAzJjHQQ==
-
 noop-logger@^0.1.1:
   version "0.1.1"
   resolved "https://registry.yarnpkg.com/noop-logger/-/noop-logger-0.1.1.tgz#94a2b1633c4f1317553007d8966fd0e841b6a4c2"
@@ -1528,11 +1523,6 @@ wide-align@^1.1.0:
   dependencies:
     string-width "^1.0.2 || 2"
 
-"windows-argv-parser@file:../vendor/windows-argv-parser":
-  version "0.0.1"
-  dependencies:
-    node-addon-api "^7.0.0"
-
 winston-transport@^4.5.0:
   version "4.5.0"
   resolved "https://registry.yarnpkg.com/winston-transport/-/winston-transport-4.5.0.tgz#6e7b0dd04d393171ed5e4e4905db265f7ab384fa"