Merge pull request desktop#18436 from desktop/move-to-apps-folder-goe…

…s-brrr Replace `<br />` with `<p>` for improved accessibility in dialogs
shiftkey · Apr 10, 2024 · 19ae43e · 19ae43e
2 parents 1b7a555 + 6811a64
commit 19ae43e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/app/src/ui/delete-branch/delete-branch-dialog.tsx b/app/src/ui/delete-branch/delete-branch-dialog.tsx
@@ -49,12 +49,14 @@ export class DeleteBranch extends React.Component<
         ariaDescribedBy="delete-branch-confirmation-message delete-branch-confirmation-message-remote"
       >
         <DialogContent>
-          <p id="delete-branch-confirmation-message">
-            Delete branch <Ref>{this.props.branch.name}</Ref>?<br />
-            This action cannot be undone.
-          </p>
+          <div id="delete-branch-confirmation-message">
+            <p>
+              Delete remote branch <Ref>{this.props.branch.name}</Ref>?
+            </p>
+            <p>This action cannot be undone.</p>
 
-          {this.renderDeleteOnRemote()}
+            {this.renderDeleteOnRemote()}
+          </div>
         </DialogContent>
         <DialogFooter>
           <OkCancelButtonGroup destructive={true} okButtonText="Delete" />

diff --git a/app/src/ui/delete-branch/delete-remote-branch-dialog.tsx b/app/src/ui/delete-branch/delete-remote-branch-dialog.tsx
@@ -45,9 +45,9 @@ export class DeleteRemoteBranch extends React.Component<
         <DialogContent>
           <div id="delete-branch-confirmation-message">
             <p>
-              Delete remote branch <Ref>{this.props.branch.name}</Ref>?<br />
-              This action cannot be undone.
+              Delete remote branch <Ref>{this.props.branch.name}</Ref>?
             </p>
+            <p>This action cannot be undone.</p>
 
             <p>
               This branch does not exist locally. Deleting it may impact others

diff --git a/app/src/ui/move-to-applications-folder.tsx b/app/src/ui/move-to-applications-folder.tsx
@@ -47,8 +47,8 @@ export class MoveToApplicationsFolder extends React.Component<
             We've detected that you're not running GitHub Desktop from the
             Applications folder of your machine. This could cause problems with
             the app, including impacting your ability to sign in.
-            <br />
-            <br />
+          </p>
+          <p>
             Do you want to move GitHub Desktop to the Applications folder now?
             This will also restart the app.
           </p>