Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for velog #2323

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Add support for velog #2323

merged 3 commits into from
Nov 1, 2024

Conversation

Nuung
Copy link
Contributor

@Nuung Nuung commented Oct 9, 2024

This PR addresses issue #2322 by adding support for detecting usernames on Velog.

  1. I did tox testing by local after editing data.json file
  2. and I ran python -m sherlock_project qlgks1 nonewould_everuserthis7 --no-txt --site velog --local --print-all
스크린샷 2024-10-09 오후 6 52 15

@Tzurrr Tzurrr mentioned this pull request Oct 11, 2024
Closed
@Nuung Nuung mentioned this pull request Oct 21, 2024
Closed
@Nuung
Copy link
Contributor Author

Nuung commented Oct 21, 2024

Hi @ppfeister, please check this out :) 👍

ppfeister
ppfeister approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@ppfeister ppfeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Appreciate the add
Merging into master

@ppfeister ppfeister merged commit 0e57691 into sherlock-project:master Nov 1, 2024
16 checks passed
@ppfeister ppfeister linked an issue Nov 1, 2024 that may be closed by this pull request
Requesting support for: Velog #2322
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppfeister ppfeister ppfeister approved these changes

@sdushantha sdushantha Awaiting requested review from sdushantha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requesting support for: Velog
2 participants
@Nuung @ppfeister