add Bluesky support (#2302) #2303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NitroType throws status_code 302 which is QueryStatus.AVAILABLE as defined in here: https://github.com/sherlock-project/sherlock/blob/master/sherlock_project/sherlock.py#L458-L459
Lichess throws 404 if a username is available
Kick's changed their error message from "Not Found" to "Oops, something went wrong"
Houzz throws 404 if a username is available
Comment on lines
+2803
to
+2805
| "errorMsg": "<title>@{} — Bluesky</title>", | ||
| "errorType": "message", | ||
| "url": "https://bsky.app/profile/{}.bsky.social", |
There was a problem hiding this comment.
I'm not sure this is going to work super well. If the user doesn't have a display name, I think the title of the page will match this even if the user exists. It might be better to use the status_code errorType and then specify the actual API call that looks up the user. That should respond with a 400 if the user doesn't exist. The API call would be https://public.api.bsky.app/xrpc/com.atproto.identity.resolveHandle?handle={}.bsky.social
There was a problem hiding this comment.
Hey @ibnaleem before I run through things do you have any thoughts here?
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Bluesky (bsky.app) to data.json.