Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fanpop #2269

Closed
wants to merge 0 commits into from
Closed

Add Fanpop #2269

wants to merge 0 commits into from

Conversation

ntexe
Copy link
Contributor

@ntexe ntexe commented Aug 23, 2024

Closes #2268

I have added Fanpop site which was removed earlier.

ntexe
ntexe commented Aug 23, 2024
View reviewed changes
Copy link
Contributor Author

@ntexe ntexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I've made a couple of commits to make my PR pass the tests. It works
image

@ntexe ntexe mentioned this pull request Aug 23, 2024
Closed
1 task
@ntexe
Copy link
Contributor Author

ntexe commented Aug 24, 2024 •
edited
Loading

Hi @ppfeister, please check this out :)

@ppfeister ppfeister closed this Aug 28, 2024
ppfeister pushed a commit that referenced this pull request Aug 28, 2024
@ntexe
Restore Fanpop
f7075e1 
Cleaned up commit for #2269
@ppfeister
Copy link
Member

Good add!

Tried to squash your commits and the forge imploded. git handled it well, GitHub did not. So while GitHub is showing this PR as closed, your changes actually did get merged under the commit f7075e1. Also visible when searching for authored commits in the repo [click].

@ntexe
Copy link
Contributor Author

ntexe commented Aug 30, 2024

@ppfeister Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requesting support for: Fanpop
2 participants
@ntexe @ppfeister