Stop mousedown event propogation when calling toggle #1507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mousedown event propagation is not stopped in all cases: only currently when you click the "caret" icon. This makes all mousedown events also stop propogation.
This was found to cause strange behavior in cases where other components were also listening for mousedown events. For example, the Vue Headless UI Dialog from Tailwind also uses a mousedown event, and not stopping propagation was causing the modal to close any time the multiselect component was clicked without
.stop
on the mousedown event.I didn't include a reproduction link because the caret already has
.stop
on the propagation and this makes it consistent, but please let me know if you would like one.