Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastbin_dup_consolidate.c revamp #191

Merged
merged 3 commits into from
May 26, 2024
Merged

fastbin_dup_consolidate.c revamp #191

merged 3 commits into from
May 26, 2024

Conversation

k4lizen
Copy link
Contributor

@k4lizen k4lizen commented May 21, 2024

I cleaned it up a bit.

  • glibc versions 2.31 and 2.27 don't have safe linking so I removed the comments about that
  • glibc versions 2.23 and 2.24 dont have tcache so I reworked it so it doesn't mention tcache

Closes #187

@k4lizen
Copy link
Contributor Author

k4lizen commented May 21, 2024

Also for some reason I'm having trouble testing it on older version of glibc, so if someone could verify that it works (particularly the versions without tcache), thatd be great.

@Kyle-Kyle
Copy link
Contributor

it seems that it passes the CI, thanks for your contribution!

@Kyle-Kyle Kyle-Kyle merged commit bf2909a into shellphish:master May 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fastbin_dup_consolidate wrong explanation
2 participants