Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix, Makefile now works on oldlist versions #185

Merged
merged 1 commit into from
May 2, 2024

Conversation

goreil
Copy link
Contributor

@goreil goreil commented May 2, 2024

The new Makefile Feature #180 did not work for some glibc versions as it always downloaded 2.21-0ubuntu4.3_amd64 instead of the actual target version.

This affected every version inside of the "glibc-all-in-one/old_list", i.e. version 2.24, 2.26,2.28.

Bugtrace

$ H2H_USE_SYSTEM_LIBC=N make v2.24
git submodule update --init --recursive
cd glibc-all-in-one && ./update_list
[+] Common list has been save to "list"
[+] Old-release list has been save to "old_list"
download_glibc_2.24
version=2.24; \
libc=$(cat glibc-all-in-one/list | grep "$version" | grep "amd64" | head -n 1); \
old_libc=$(cat glibc-all-in-one/old_list | grep "" | grep "amd64" | head -n 1); \
if [ -z $libc ]; then libc=$old_libc; script="download_old"; else libc=$libc; script="download"; fi; \
cd glibc-all-in-one; \
rm -rf libs/$libc; \
./$script $libc
Getting 2.21-0ubuntu4.3_amd64
  -> Location: http://old-releases.ubuntu.com/ubuntu/pool/main/g/glibc/libc6_2.21-0ubuntu4.3_amd64.deb

This pull request remedies the issue

@Kyle-Kyle
Copy link
Contributor

thank you for the fix!

@Kyle-Kyle Kyle-Kyle merged commit df11470 into shellphish:master May 2, 2024
12 checks passed
@goreil goreil deleted the bugfix-oldlist branch May 3, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants