some corrections and a little refactoring of the activemq.xml template #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2019 21:16
- renamed variables starting with activemq_ to amq_ to be more
consistent with previous version(s)
- added a custom log4j.properties template
- added default username/password to activemq broker config
- changed the build up of the amq_transport connectors in the
activemq.xml.j2 template to be more flexible
- bumped default versdion to 5.15.8
tasks/tarbal.yml
- noted some typo's in name: blocks, corrected them and might have
introduced new typo's xD
- getting the tarball with ansible: unarchive instead of get_url
- no need to generate 'empty log file', just make sure the directory is
owned by {{ amq_user }}
activemq.xml.j2
- changed activemq_instance_name to amq_broker_name to be more
consistent with the .xml file.
(and the previous change of renaming activemq_ to amq_ in all
variables)
- building up the <transportConnectors> in a similar way as the {{
amq_env_vars }} are used
- custom log4j.properties file
made it possible to change to 'default' logfile location to: {{
amq_log_dir }}/activemq.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modifications:
defaults/main.yml
tasks/tarbal.yml
activemq.xml.j2
changed activemq_instance_name to amq_broker_name to be more consistent with the .xml file.
(and the previous change of renaming activemq_ to amq_ in all variables)
building up the in a similar way as the {{ amq_env_vars }} are used
custom log4j.properties file
made it possible to change to 'default' logfile location to: {{ amq_log_dir }}/activemq.log