Update planner #50
Closed
Update planner #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tangruilin PTAL. we can disscuss here. The basic feature i had finish it. |
Tangruilin
reviewed
Feb 1, 2024
| use super::column::Column; | ||
|
|
||
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct Schema { |
There was a problem hiding this comment.
schema 的概念是用来管理 tables 的，你这里这个 Schema 更类似于 Table 的概念
There was a problem hiding this comment.
参考 datafusion 的 SchemaProvider，这里应该是 table_names
Tangruilin
reviewed
Feb 1, 2024
| use super::schema::Schema; | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct TableInfo { |
There was a problem hiding this comment.
Table 里面才会去管理 Column 吧
但是你这里这个 Table 看不到 Column 的元信息？
|
Closed by #52, will split multi pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR solve? (这个 PR 解决了什么问题)
Retionable for this PR Change (这个 PR 做了什么改变)