Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer whiskers plot #727

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

serpent7776
Copy link
Contributor

  • add missing encoding when opening input file
  • add labels to x ticks, rotated by 45 deg
  • sort data by median, ascending

I like this layout much more, but if needed I can hide new functionality behind command line flags.

- add missing encoding when opening input file
- add labels to x ticks, rotated by 45 deg
- sort data by median, ascending
@sharkdp
Copy link
Owner

sharkdp commented Mar 13, 2024

Thank you!

Can you provide a before-and-after screenshot?

sort data by median, ascending

This would be nice to have as an option, but I prefer benchmarks to be ordered by input ordering — by default.

@serpent7776
Copy link
Contributor Author

Sure, here's the old version:

plot_old

This is the new version (one issue is that longer labels are cut off):

plot_new

I can fix the issue by applying plt.figure(figsize=(10, 6), constrained_layout=True), but I don't know why this works:

plot_sized

@sharkdp
Copy link
Owner

sharkdp commented Mar 13, 2024

Cool — looks great! If we can hide the sorting feature behind a command line option (maybe --sort-by=…), I'm happy to merge this.

@serpent7776
Copy link
Contributor Author

Updated the code.

@sharkdp
Copy link
Owner

sharkdp commented Mar 14, 2024

Thank you

@sharkdp sharkdp merged commit 51d056a into sharkdp:master Mar 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants