refactor: Optimize code based on cargo clippy suggestions

Signed-off-by: one230six <[email protected]>

src/command.rs

@@ -62,7 +62,7 @@ impl<'a> Command<'a> {
         let parameters =
             self.get_unused_parameters()
                 .fold(String::new(), |output, (parameter, value)| {
-                    output + &format!("{} = {}, ", parameter, value.to_string())
+                    output + &format!("{} = {}, ", parameter, value)
                 });
         let parameters = parameters.trim_end_matches(", ");
         let parameters = if parameters.is_empty() {

src/parameter/mod.rs

@@ -1,3 +1,4 @@
+use std::fmt::Display;
 use crate::util::number::Number;
 
 pub mod range_step;
@@ -9,12 +10,13 @@ pub enum ParameterValue {
     Numeric(Number),
 }
 
-impl ToString for ParameterValue {
-    fn to_string(&self) -> String {
-        match self {
+impl Display for ParameterValue {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        let str = match self {
             ParameterValue::Text(ref value) => value.clone(),
             ParameterValue::Numeric(value) => value.to_string(),
-        }
+        };
+        write!(f, "{}", str)
     }
 }
 

src/util/min_max.rs

@@ -1,4 +1,3 @@
-use std::iter::Iterator;
 
 /// A max function for f64's without NaNs
 pub fn max(vals: &[f64]) -> f64 {