Add ripgrep aliases for no-ignore and hidden #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fantastic! Thank you very much for your contribution and welcome to Rust! 👍 I added just a short comment regarding three or more (possible) occurences of |
sharkdp
reviewed
Oct 11, 2017
src/main.rs
Outdated
| @@ -86,8 +86,8 @@ fn main() { | |||
| let config = FdOptions { | |||
| case_sensitive: case_sensitive, | |||
| search_full_path: matches.is_present("full-path"), | |||
| ignore_hidden: !matches.is_present("hidden"), | |||
| read_ignore: !matches.is_present("no-ignore"), | |||
| ignore_hidden: !(matches.is_present("hidden") || matches.occurrences_of("rg-alias-hidden-ignore") == 2), | |||
There was a problem hiding this comment.
We could potentially set this to .. >= 2, right?
ripgrep has up to three occurences of -u, so someone might try to be on the safe side by putting -uuu. Just a thought.. I think it wouldn't hurt.
|
Thanks, done. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-uand-uualiases for no-ignore and no-ignore+hidden to match behaviour of ripgrep. This fixes #92.Note: I have implemented this using a hidden argument. I am new to rust so please let me know if there is a more idiomatic approach.