Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fd.1 man page, close #77 #125

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Add fd.1 man page, close #77 #125

merged 2 commits into from
Oct 19, 2017

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Oct 17, 2017

#77

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this contribution!

I've added a few inline comments in the review.

@@ -0,0 +1,106 @@
.TH FD 1 fd-4.0.0
.SH NAME
fd \- find files
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be a little bit more detailed: "fd - find entries in the filesystem"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took that from the posix man page and sbase man page. Both uses that.

.TH FD 1 fd-4.0.0
.SH NAME
fd \- find files
.BR find (1)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? is it a link to find? Do we need this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a link to find since it's on the current description.

doc/fd.1 Outdated
fd \- find files
.BR find (1)
.SH SYNOPSIS
.B spt
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fd, probably 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, sorry. :P

doc/fd.1 Outdated
.B \-H, \-\-hidden
Search hidden files and directories.
.TP
.B \-I, \-\-no\-gitignore
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be --no-ignore.

doc/fd.1 Outdated
.BR gitignore (5)
files.
.TP
.B \-s, \-\-case\-insensitive
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be --case-sensitive

doc/fd.1 Outdated
.B \-h, \-\-help
Prints help information.
.TP
.B \-v, \-\-version
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be -V, not -v.

doc/fd.1 Outdated
.TP
.BI "\-j, \-\-threads " num
Specifies number of threads to use for searching. (default: number of available
CPU cores)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add the new option -x, --exec?

doc/fd.1 Outdated
.TP
LS_COLORS
.BR "fd"'s
color codes for search results.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LS_COLORS is also used by ls and typically set by dircolors. Maybe we should say something like: "determines how to colorize the search results, see DIRCOLORS(1)".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion, I don't have better idea to write this environment part.

doc/fd.1 Outdated
.SH EXAMPLES
.TP
.RI "Find the specific log files in " /var/log .
$ fd nginx.log /var/log
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just use fd nginx /var/log here. The . can actually mean "any character" in a regex, so this does not perform a literal search for "nginx.log".

Maybe in the future we need to redirect `--help` to the man pages? Is there a way for cargo to install the man pages?
@pickfire pickfire changed the title Add fd.1 man page Add fd.1 man page, fix #77 Oct 19, 2017
@pickfire pickfire changed the title Add fd.1 man page, fix #77 Add fd.1 man page, close #77 Oct 19, 2017
@sharkdp
Copy link
Owner

sharkdp commented Oct 19, 2017

Fantastic, thank you very much!

@sharkdp sharkdp merged commit ddfa087 into sharkdp:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants