Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRI-59: Fix improper input validation in safeJsonParse #17

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

jintukumardas
Copy link

Linear: https://linear.app/shm/issue/PRI-59
Summary: Added input type validation for base64 and unit tests

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Key issues to review

Type Checking
The type checking for originalObject.value only checks for string type but does not validate if the string is a valid base64 format. This might still allow invalid base64 strings to pass through until they are processed, potentially leading to errors at runtime.

arhamj
arhamj previously approved these changes Aug 21, 2024
@jintukumardas jintukumardas dismissed arhamj’s stale review August 21, 2024 06:54

The merge-base changed after approval.

@mhanson-github mhanson-github merged commit 4274ad9 into dev Aug 30, 2024
7 checks passed
@mhanson-github mhanson-github deleted the PRI-59 branch September 2, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants