Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RED-201: Network Generated Transactions #16

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

urnotsam
Copy link

No description provided.

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Type Safety
The AddNetworkTx interface uses a generic type T for txData without constraints, which might lead to issues with type safety if misused.

Missing Documentation
New interfaces and types such as AddNetworkTx, RemoveNetworkTx, and Record are introduced without inline documentation. Adding comments explaining their purpose and usage would enhance code maintainability and readability.

@urnotsam urnotsam requested a review from a team as a code owner August 26, 2024 15:08
rename serviceEntry

add module export for serviceQueue

add activeCycle to node

update types for new more generic serviceQueue approach

update types

add signed types

define ServiceQueueTypes.Txs + add NetworkTxEntry type

add subQueueKey for addNetworkTx

add has to AddNetworkTx

make AddNetworkTx generic

add involvedaddress type

Revert "add involvedaddress type"

This reverts commit 861ded4.

Sys 183 add GitHub ci (#14)

* fixing issue comment Pr review stuff

* add codeowners, sync ci.yml, fix scripts

* cleanup gitlab.ci

* fixed quotes
add new typings for cycle txs

Add unjoin request to types

remove lostAfterSelectionRequest

Bump the npm_and_yarn group across 1 directory with 2 updates

Bumps the npm_and_yarn group with 2 updates in the / directory: [braces](https://github.com/micromatch/braces) and [ws](https://github.com/websockets/ws).


Updates `braces` from 3.0.2 to 3.0.3
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

Updates `ws` from 7.5.9 to 7.5.10
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.5.9...7.5.10)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: ws
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
Added input type validation for base64 and unit tests
@mhanson-github mhanson-github merged commit 10fbf48 into dev Sep 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants