SYS-164 added workflow to run linter and trigger smoke tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TieDyedSheep
force-pushed
the
SYS-164-basic-github-build-pipeline
branch
4 times, most recently
from
755c06c
to
ade1042
Compare
muni-corn
previously approved these changes
May 15, 2024
|
Looks good to me! |
TieDyedSheep
force-pushed
the
SYS-164-basic-github-build-pipeline
branch
from
9452be8
to
682274d
Compare
|
This is the Jenkins job I trigger, it was provided parameters to override the shardus_types parameters with the branch from the PR and this triggered it's own action and ran successfully |
chrypnotoad
reviewed
May 16, 2024
chrypnotoad
approved these changes
May 17, 2024
|
This was approved and the approval was removed when I resolved a conversation so I'm just bypassing and merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a github action yaml to to basic builds, linting, test the patches can be applied and finally trigger the Jenkins smoke test job. If no patches exist, the job will skip that step. if the build, linting, formatter or patches fail, the workflow will fail.