Skip to content

Commit

Permalink
SYS-190 add github ci
Browse files Browse the repository at this point in the history
fixing issue comment Pr review stuff

add codeowners and sync ci.yml

fixed quotes on lint script, added format-fix

cleanup gitlab.ci
  • Loading branch information
TieDyedSheep authored and mhanson-github committed Jul 30, 2024
1 parent a19a293 commit d5ebb7f
Show file tree
Hide file tree
Showing 4 changed files with 92 additions and 47 deletions.
77 changes: 77 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
name: Node CI Workflow
#
# The parameters are defaulted at the org level but can be overridden on the repository.
# See the github-automation repo for more documentation
#
on:
push:
branches:
- dev
- main
pull_request:
branches:
- dev
- main
issue_comment:
inputs:
workflowBranch:
description: 'Branch of the reusable workflow. Defaults to main, select dev for testing only.'
required: true
default: 'main'
type: choice
options:
- dev
- main
workflow_dispatch:
inputs:
workflowBranch:
description: 'Branch of the reusable workflow. Defaults to main, select dev for testing only.'
required: true
default: 'main'
type: choice
options:
- dev
- main
jobs:
echo-inputs:
name: Repo Workflow Debugging
runs-on: ubuntu-latest
steps:
- name: Check Repo Vars
run: |
echo "*** Start - Check inputs in repo workflow ***"
echo "Node Version: ${{ vars.NODE_VERSION }}"
echo "Lint Required: ${{ vars.IS_LINT_REQUIRED }}"
echo "Format Check Required: ${{ vars.IS_FORMAT_CHECK_REQUIRED }}"
echo "Apply Patches Required: ${{ vars.IS_APPLY_PATCHES_REQUIRED }}"
echo "Unit Tests Required: ${{ vars.IS_UNIT_TESTS_REQUIRED }}"
echo "*** End - Check inputs in repo workflow ***"
ci-test-only:
if: ${{ github.event.inputs.workflowBranch == 'dev' }}
uses: shardeum/github-automation/.github/workflows/reusable-node-ci.yml@dev
permissions:
issues: write
pull-requests: write
contents: write
with:
node-version: ${{ vars.NODE_VERSION }}
lint-required: ${{ vars.IS_LINT_REQUIRED == 'true' }}
format-check-required: ${{ vars.IS_FORMAT_CHECK_REQUIRED == 'true' }}
apply-patches-required: ${{ vars.IS_APPLY_PATCHES_REQUIRED == 'true' }}
unit-tests-required: ${{ vars.IS_UNIT_TESTS_REQUIRED == 'true' }}
secrets: inherit

ci:
if: ${{ github.event.inputs.workflowBranch == 'main' || !github.event.inputs.workflowBranch }}
uses: shardeum/github-automation/.github/workflows/reusable-node-ci.yml@main
permissions:
issues: write
pull-requests: write
contents: write
with:
node-version: ${{ vars.NODE_VERSION }}
lint-required: ${{ vars.IS_LINT_REQUIRED == 'true' }}
format-check-required: ${{ vars.IS_FORMAT_CHECK_REQUIRED == 'true' }}
apply-patches-required: ${{ vars.IS_APPLY_PATCHES_REQUIRED == 'true' }}
unit-tests-required: ${{ vars.IS_UNIT_TESTS_REQUIRED == 'true' }}
secrets: inherit
45 changes: 0 additions & 45 deletions .gitlab-ci.yml

This file was deleted.

13 changes: 13 additions & 0 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# CODEOWNERS file
# To add additional teams to any approval, include them on the same line separated by spaces
# It is best practice to assign a team as a code owner and not an invidual.
# Please submit requests for new teams to Systems and Automation

# Global approval (all files)
# * @shardeum/team-name

# Directory-level approval
/.github/ @shardeum/systems-and-automation

# Specific file rules
# README.md @shardeum/team-name
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
"test": "test"
},
"scripts": {
"lint": "eslint './src/**/*.ts'",
"lint-windows": "eslint ./src/**/*.ts",
"lint": "eslint \"./src/**/*.ts\"",
"format-check": "prettier --check './src/**/*.ts'",
"format-fix": "prettier --write './src/**/*.ts'",
"prepare": "npm run compile",
"prepublish": "npm run compile",
"pretest": "npm run compile",
Expand Down

0 comments on commit d5ebb7f

Please sign in to comment.