Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLUE-254: /totalData DB queries optimised #77

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

achal-singh
Copy link
Contributor

Summary

This PR tweaks the COUNT query across the 5 databases in the Archiver to serve data to the /totalData API. The goal is to optimise the API, making it as lightweight as possible in preparation for the upcoming alerting system.

Linear Task

@achal-singh achal-singh self-assigned this Sep 8, 2024
Copy link

github-actions bot commented Sep 8, 2024

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Possible Bug
The function name queryCyleCount in CycleDB is misspelled. It should be queryCycleCount to maintain consistency and avoid potential bugs due to typos.

Data Integrity
The SQL query in queryOriginalTxDataCount does not handle the case where startCycle and endCycle are provided but not used in the query due to missing parameters in the values array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant