Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trade countdown fixes #7809

Merged
merged 5 commits into from
Sep 25, 2024
Merged

fix: trade countdown fixes #7809

merged 5 commits into from
Sep 25, 2024

Conversation

gomesalexandre
Copy link
Contributor

Description

Fixes countdown twofolds:

  1. was never able to get the countdown to run to start with on localhost - fixed by removing seemingly useless reset which means the countdown would previously never decrease
  2. only start running countdown on swap Txid

Issue (if applicable)

closes #7806

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • Swap confirm countdown is still happy
  • Swap confirm countdown only runs on Txid received (i.e, Tx signed and broadcasted)

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/7a7d4421-cc46-4982-84e3-fc447f0515c5

@gomesalexandre gomesalexandre marked this pull request as ready for review September 25, 2024 15:05
@gomesalexandre gomesalexandre requested a review from a team as a code owner September 25, 2024 15:05
woodenfurniture
woodenfurniture approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@woodenfurniture woodenfurniture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

src/components/MultiHopTrade/components/MultiHopTradeConfirm/hooks/useCountdown.tsx Outdated Show resolved Hide resolved
src/components/MultiHopTrade/components/MultiHopTradeConfirm/components/Hop.tsx Show resolved Hide resolved
src/components/MultiHopTrade/components/MultiHopTradeConfirm/hooks/useCountdown.tsx Outdated Show resolved Hide resolved
@gomesalexandre gomesalexandre enabled auto-merge (squash) September 25, 2024 22:42
@gomesalexandre gomesalexandre merged commit ac35b93 into develop Sep 25, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the fix_trade_countdown_improvements branch September 25, 2024 22:56
@gomesalexandre gomesalexandre mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodenfurniture woodenfurniture woodenfurniture approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lifi bridge timer starts counting down before executing the trade
3 participants
@gomesalexandre @woodenfurniture @0xApotheosis