feat: markets page watchlist #7795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
commented
Sep 24, 2024
| @@ -96,6 +96,7 @@ export const AssetHeader: React.FC<AssetHeaderProps> = ({ assetId, accountId }) | |||
| {name} {`(${symbol}${asset.id ? ` ${middleEllipsis(asset.id)}` : ''})`} | |||
| </Heading> | |||
|
|
|||
| <WatchAssetButton assetId={assetId} /> | |||
There was a problem hiding this comment.
@reallybeard FYI, this adds watchlist capabilities on asset page for consistency with mobile
gomesalexandre
commented
Sep 24, 2024
| }, [appDispatch, assetId, isAssetIdWatched]) | ||
| const handleToggleWatchAsset: React.MouseEventHandler<HTMLButtonElement> = useCallback( | ||
| e => { | ||
| e.stopPropagation() |
There was a problem hiding this comment.
Allows the larger hitbox of the card not to fire its own onClick
gomesalexandre
commented
Sep 24, 2024
gomesalexandre
force-pushed
the
feat_markets_category
branch
from
df19d6f
to
ea7b778
Compare
gomesalexandre
force-pushed
the
feat_watchlist
branch
from
631a865
to
091f2ea
Compare
gomesalexandre
force-pushed
the
feat_markets_category
branch
from
ea7b778
to
b94e3a7
Compare
gomesalexandre
force-pushed
the
feat_watchlist
branch
from
091f2ea
to
755121b
Compare
gomesalexandre
force-pushed
the
feat_markets_category
branch
from
b94e3a7
to
4a722a1
Compare
gomesalexandre
force-pushed
the
feat_watchlist
branch
from
755121b
to
91cdebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds watchlist tab / icon to the markets page.
Issue (if applicable)
closes #7685
Risk
Low
Testing
Engineering
Operations
Screenshots (if applicable)