Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: markets category route #7794

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: markets category route #7794

wants to merge 2 commits into from
+701 −372

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Sep 24, 2024 •
edited
Loading

Description

Does what it says on the box - adds a category/ route for a single category, with a 100 assets limit

Issue (if applicable)

closes #7683

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

  • Clicking to a category title links to a single category page
  • Tabs and regular page heading isn't present on category page
  • More assets than the 8 on recommended page are displayed (max is 100, though given we don't support all upstream supported ChainIds e.g Solana, actual count may be less depending on categories)

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Screenshot 2024-09-24 at 12 07 30 Screenshot 2024-09-24 at 12 07 36 Screenshot 2024-09-24 at 12 07 49 Screenshot 2024-09-24 at 12 07 56 Screenshot 2024-09-24 at 12 08 08

@gomesalexandre gomesalexandre requested a review from a team as a code owner September 24, 2024 10:10
@gomesalexandre gomesalexandre force-pushed the feat_markets_category branch 2 times, most recently from ea7b778 to b94e3a7 Compare September 25, 2024 10:01
Base automatically changed from feat_coingecko_recommended to develop September 25, 2024 10:11
kaladinlight
kaladinlight reviewed Sep 25, 2024
View reviewed changes
src/pages/Markets/Category.tsx
const ASSETS_LIMIT = 100

export const Category: React.FC = () => {
const params: { category: MARKETS_CATEGORIES } = useParams()
Copy link
Contributor

@kaladinlight kaladinlight Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick suggestion

Suggested change
const params: { category: MARKETS_CATEGORIES } = useParams()
const params = useParams<{ category: MARKETS_CATEGORIES }>()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markets Page : Category Page
2 participants
@gomesalexandre @kaladinlight