-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: savers consistent withdraw dust amount #7780
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
commented
Sep 20, 2024
...ders/thorchain-savers/components/ThorchainSaversManager/Overview/ThorchainSaversOverview.tsx
Outdated
Show resolved
Hide resolved
gomesalexandre
commented
Sep 20, 2024
...providers/thorchain-savers/components/ThorchainSaversManager/Withdraw/components/Confirm.tsx
Outdated
Show resolved
Hide resolved
…/ThorchainSaversManager/Withdraw/components/Confirm.tsx
gomesalexandre
commented
Sep 20, 2024
kaladinlight
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug spotted while working on #7766
I was unable to broadcast a withdraw Tx, and while debugging things out, noticed that the sum of all my UTXOs was lower than the dust balance value being sent.
The reason behing this is that
useSendThorTx()
uses default dust amounts, while THORChain savers withdraw confirm step uses upstream dust amount (lower), which meant balance checks weren't working.Issue (if applicable)
closes N/A
Risk
Low
Testing
Engineering
Operations
Screenshots (if applicable)