Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keepkey eip-712 signing #5553

Merged
merged 2 commits into from
Oct 29, 2023
Merged

fix: keepkey eip-712 signing #5553

merged 2 commits into from
Oct 29, 2023

Conversation

kaladinlight
Copy link
Contributor

@kaladinlight kaladinlight commented Oct 27, 2023

Description

Bump hdwallet to fix keepkey EIP-712 signing

Pull Request Type

  • πŸ› Bug fix (Non-breaking Change: Fixes an issue)
  • πŸ› οΈ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • πŸ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5384

Risk

Low - isolated to keepkey

Testing

  • OpenSea message signing
  • Any other relevant dapp message signing

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

image

@kaladinlight kaladinlight requested a review from a team as a code owner October 27, 2023 16:41
@0xApotheosis 0xApotheosis merged commit bf9033b into develop Oct 29, 2023
3 checks passed
@0xApotheosis 0xApotheosis deleted the bump-hdwallet branch October 29, 2023 19:26
@0xApotheosis
Copy link
Contributor

Related HDWallet PR: shapeshift/hdwallet#649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WalletConnect To DApps: "Invalid order signature" when attempting to list an NFT for auction
2 participants