fixes TRST-M-1 - adds additional padding for precision loss #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we don't plan to use this for tokens with > 18 decimals or more than 1 billion staked tokens, we can still add some additional padding to make the contract more flexible and future proof.
This adds additional padding to the REWARD_RATE which is the same outcome as suggested by the auditors it also adds additional paranoia in testing by increasing the supply of test fox tokens and the number of years we check for overflow on.
note: this doesn't divide by the increase as suggested by Trust in the audit - but I don't think that is required based on the expected use case here and the checks for overflow.