feat: gracefully handle mm impersonators #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
gomesalexandre
changed the title
gomesalexandre
force-pushed
the
feat_improve_mm_impersonator_checks
branch
from
aa9f3f2
to
e13522e
Compare
3 tasks
There was a problem hiding this comment.
Code-wise looking sane, will give it a runtime test with shapeshift/web#5896.
0xApotheosis
force-pushed
the
feat_improve_mm_impersonator_checks
branch
from
e13522e
to
601d04c
Compare
0xApotheosis
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Runtime is also looking sane against shapeshift/web#5896 👌
I'm getting a snaps install prompt with using actual metamask, but not when using Brave Wallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
wallet_getSnapsMM JSON-RPC request to impersonators, which would failisUnlockedmethod not implemented, e.g https://github.com/zeriontech/zerion-wallet-extension/blob/294630a4e1ef303205a6e6dd681245a27c8d1eec/src/modules/ethereum/provider.ts#L36C1-L39In conjunction with the matching web PR (shapeshift/web#5896), this allows to connect previously not working MM impersonators like Zerion wallet extension.
Screenshots