perf: remove argon bench on boot, use sane defaults across the board

[woodenfurniture]

Overview

Hardcodes sensible defaults for argon encryption parameters, skipping the benchmark to reduce initial app boot time by >4s on both desktop and mobile devices, when connecting to native wallet for the first time.

The default parameters remain the same, with only the iterations changing from 23 to 16. Noting that reasonably modern mobile devices achieve ~11 iterations within the 1s target, the default was set to a conservative 16 iterations as a balance between performance and security.

Testing

This should be tested locally with shapeshift web via local npm registry (e.g verdaccio)

• can open native wallet with existing local state (existing parameters set in IndexedDB with prior benchmark on prior version version). This should prove backwards compatibility so users don't have to re-import their wallets
• can open native wallet starting from empty local state (clear IndexedDB)

Issue

Will close #5557 after bumping version in web.

Benchmark parameters

Mobile - Pixel 4a
Note overall duration of the bench was 4.1s

Desktop - Mac M2
Note overall duration of the bench was 4.6s

Performance results (on Desktop - Mac M2)

Before changes
4s benchmark runs on first open of native wallet:

After changes
4s benchmark no longer run:

Note the defaults get stored as intended:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hdwallet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 28, 2023 10:01am

[gomesalexandre]

Tested locally, LGTM pending security green light on this:

• Existing state - unlock native wallet

existing.wallet.mov

• Cleared state - Import wallet

import.mov

• Cleared state - new wallet creation

new.wallet.mov

[gomesalexandre]

Current dependencies on/for this PR:

• master
  • PR perf: remove argon bench on boot, use sane defaults across the board #654 👈

This stack of pull requests is managed by Graphite.

[0xApotheosis]

Solid big wood

[gomesalexandre]

Stamping as previously reviewed/tested, implementation didn't change and this has ops green light 🥇