Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: KeepKey produces accurate EIP-712 eth_signTypedData_v4 signatures #649

Merged
merged 19 commits into from
Oct 27, 2023
Merged

fix: KeepKey produces accurate EIP-712 eth_signTypedData_v4 signatures #649

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f847bf5
Fix ethSignTypedData so that the signing address can be recovered fro…
0xMillz Oct 18, 2023
1045c4a
Update Sandbox ethSignTypedData to verify that signature is accurate …
0xMillz Oct 18, 2023
33d5302
Merge in master, fix conflicts
0xMillz Oct 18, 2023
c4766cf
Merge in master again, fix conflicts
0xMillz Oct 18, 2023
d1ab981
Merge branch 'master' into fix_kk_ethSignTypedData
BitHighlander Oct 23, 2023
b5fa182
Revert "Merge branch 'master' into fix_kk_ethSignTypedData"
0xMillz Oct 23, 2023
f51a8bf
remove ethereumjs-util since we already have web3.utils
0xMillz Oct 23, 2023
cd29461
fix: messageHash should not be set if "EIP712Domain" is the primaryType
0xMillz Oct 24, 2023
76ae5d1
Add additional test cases
0xMillz Oct 24, 2023
dd5b547
bump hdwallet-* versions
0xMillz Oct 24, 2023
6b2ce3a
Revert "Revert "Merge branch 'master' into fix_kk_ethSignTypedData""
0xMillz Oct 24, 2023
5f8b3e3
Remove dependencies browserify-zlib and update-browserslist-db (a Sky…
0xMillz Oct 26, 2023
3206d6d
update yarn.lock by running yarn
0xMillz Oct 27, 2023
78ed4ae
move parcel back to a regular dep
0xMillz Oct 27, 2023
f6d4e25
update yarn.lock
0xMillz Oct 27, 2023
870e307
merge in master, fix conflicts
0xMillz Oct 27, 2023
a45f5a8
bump all to v1.52.11
0xMillz Oct 27, 2023
2503066
remove update-browserslist-db + caniuse-lite changes from yarn.lock
0xMillz Oct 27, 2023
640d634
ts wants this for import $ from "jquery"
0xMillz Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions examples/sandbox/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,13 @@ <h5>Arkeo</h5>
<h4>Ethereum</h4>
<button class="button button-outline" id="ethAddr">Address</button>
<button class="button button-outline" id="ethTx">Tx</button>
<button class="button button-outline" id="ethSign">Sign</button>
<button class="button button-outline" id="ethEIP1559">EIP-1559?</button>
<button class="button button-outline" id="ethSend">Send</button>
<button class="button button-outline" id="ethSign">Sign Message</button>
<button class="button button-outline" id="ethVerify">Verify</button>
<button class="button button-outline" id="ethEIP1559">EIP-1559?</button>
<button class="button button-outline" id="ethSignTypedData">Sign Typed Data</button>
<button class="button button-outline" id="ethSignTypedDataPreCalculate">Sign Typed Data (Pre-Calculate)</button>
<button class="button button-outline" id="ethSignTypedData">Sign Typed Data (OpenSea Listing)</button>
<button class="button button-outline" id="ethSignTypedDataAlternate1">Sign Typed Data (primaryType is 80+ chars)</button>
<button class="button button-outline" id="ethSignTypedDataAlternate2">Sign Typed Data (primaryType is "EIP712Domain")</button>
<input type="text" id="ethResults" />
</div>
<div class="container">
Expand Down Expand Up @@ -437,11 +438,6 @@ <h3>Mnemoic Required</h3>
</div>

<script src="https://unpkg.com/[email protected]/dist/debug.js"></script>
<script
src="https://code.jquery.com/jquery-3.3.1.min.js"
integrity="sha256-FgpCb/KJQlLNfOu91ta32o/NMZxltwRo8QtmkMRdAu8="
crossorigin="anonymous"
></script>
<script type="module" src="./index.ts"></script>
</body>
</html>
Loading
Loading