perf: optimize seed creation #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gomesalexandre
force-pushed
the
optimise-seed-creation
branch
from
6aec0ab
to
4665259
Compare
gomesalexandre
previously approved these changes
Oct 18, 2023
There was a problem hiding this comment.
LGTM, tested locally and didn't find any regression in wallet import / unlock on refresh
FYI @0xApotheosis , re-tagged the latest commit with v1.52.3 to ensure we get the no carets version published - https://github.com/shapeshift/hdwallet/releases/tag/v1.52.3
0xApotheosis
force-pushed
the
optimise-seed-creation
branch
4 times, most recently
from
4b87df7
to
1a13ad6
Compare
0xApotheosis
force-pushed
the
optimise-seed-creation
branch
from
7b467dc
to
cc583db
Compare
0xApotheosis
force-pushed
the
optimise-seed-creation
branch
from
cc583db
to
38f85ef
Compare
kaladinlight
approved these changes
Oct 18, 2023
gomesalexandre
approved these changes
Oct 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a better
pbkdf2implementation in bip39 seed creation to significantly improve performance.Related issue: shapeshift/web#5467
Before:
After: