Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WalletConnect #544

Merged
merged 19 commits into from
Jul 13, 2022
Merged

WalletConnect #544

merged 19 commits into from
Jul 13, 2022

Conversation

pastaghost
Copy link
Collaborator

@pastaghost pastaghost commented Jun 22, 2022 •
edited
Loading

Description

This adds a package for integrating WalletConnect as an adapter. This provides out-of-the box support for several mobile and desktop wallets not currently natively supported on app.shapeshift.com.

Issue

Closes #499

@vercel
Copy link

vercel bot commented Jun 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hdwallet ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 11:34PM (UTC)

@pastaghost pastaghost marked this pull request as draft June 22, 2022 15:39
@pastaghost pastaghost marked this pull request as ready for review June 22, 2022 15:59
@0xdef1cafe 0xdef1cafe mentioned this pull request Jun 27, 2022
Closed
@gomesalexandre
Copy link
Contributor

@pastaghost many package.json conflicts here

gomesalexandre
gomesalexandre reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM overall. As a full-featured hdwallet, it has some lower-level HD primitives which I'm not familiar with so stamping this will come down to testing.
How can it be tested, should we run the Sandbox or is any web integration needed?

packages/hdwallet-walletconnect/src/walletconnect.ts Show resolved Hide resolved
@gomesalexandre gomesalexandre mentioned this pull request Jul 3, 2022
Merged
5 tasks
0xdef1cafe
0xdef1cafe previously approved these changes Jul 12, 2022
View reviewed changes
packages/hdwallet-walletconnect/package.json Outdated Show resolved Hide resolved
0xdef1cafe
0xdef1cafe previously approved these changes Jul 12, 2022
View reviewed changes
gomesalexandre
gomesalexandre approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smallish comments but overall LGTM.

Untested in absence of testing steps, but this will be tested in web when installing it there.

packages/hdwallet-walletconnect/src/walletconnect.ts Show resolved Hide resolved
packages/hdwallet-walletconnect/src/walletconnect.ts Show resolved Hide resolved
@pastaghost pastaghost merged commit 748a913 into master Jul 13, 2022
@gomesalexandre gomesalexandre mentioned this pull request Jul 18, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

@0xdef1cafe 0xdef1cafe 0xdef1cafe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement WalletConnect (v1) as a dapp option into hdwallet
4 participants
@pastaghost @gomesalexandre @0xdef1cafe @majorhayes