drop legacy shapeshift MX support #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shapeshift/hdwallet/FYzui4tmSXE7GW2sEcWpBZUVaeBb |
mrnerdhair
force-pushed
the
drop-mx-support
branch
from
1ef96b5
to
faaf3fe
Compare
mrnerdhair
added
breaks-axiom
reopen-later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes
(supports|has)NativeShapeShiftfrom everything, as well asBTCSignTxOutputExchange,BTCOutputAddressType.Exchange,ExchangeType, and the KK code for encoding and processing such outputs.Context for posterity: the legacy ShapeShift US "market exchange" (MX) is dead. These features were designed to allow wallets to interact with it, and required a signature from the MX's keys to be processed. That means that literally no new outputs of these types will ever be created and this code is useless to everyone forever.