Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop legacy shapeshift MX support #454

Open
mrnerdhair opened this issue Mar 14, 2022 · 0 comments
Open

Drop legacy shapeshift MX support #454

mrnerdhair opened this issue Mar 14, 2022 · 0 comments
Labels
tech-debt A suboptimality that existed in code when it was written.
Milestone
hdwallet++

Comments

@mrnerdhair
Copy link
Contributor

The legacy ShapeShift US "market exchange" (MX) is dead. Various features of this library exist specifically to support interaction between wallets and the MX. These interactions require a signature from the MX's keys to be processed, so literally no new outputs of these types will ever be created and this code is now useless to everyone forever.

The following things should be removed:

  • supportsNativeShapeShift
  • hasNativeShapeShift
  • BTCSignTxOutputExchange
  • BTCOutputAddressType.Exchange
  • ExchangeType
  • The associated hdwallet-keepkey code for creating and processing such outputs

Fixed by #421.
@mrnerdhair mrnerdhair changed the title Drop MX support Drop legacy shapeshift MX support Mar 14, 2022
@mrnerdhair mrnerdhair added the tech-debt A suboptimality that existed in code when it was written. label Mar 14, 2022
@mrnerdhair mrnerdhair linked a pull request Mar 17, 2022 that will close this issue
drop legacy shapeshift MX support #421
Closed
@mrnerdhair mrnerdhair added this to the hdwallet++ milestone Mar 25, 2022
@mrnerdhair mrnerdhair mentioned this issue Apr 1, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt A suboptimality that existed in code when it was written.
Projects
None yet
Milestone
hdwallet++
Development

Successfully merging a pull request may close this issue.

drop legacy shapeshift MX support shapeshift/hdwallet
1 participant
@mrnerdhair