Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces re-renderings when loading documentation #30

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

simonbs
Copy link
Contributor

@simonbs simonbs commented Oct 22, 2023

This PR reduces re-rendering of pages by making two initiatives:

  1. Navigating to the full URL (/{projectId}/{versionId}/{specificationId} when selecting a project. Previously we would just navigate to /{projectId} and perform a redirect causing a second render.
  2. Relying on the useLocalStorage to load and store the select documentation visualizer.

@simonbs simonbs self-assigned this Oct 22, 2023
@simonbs simonbs merged commit 522dff1 into develop Oct 22, 2023
3 checks passed
@simonbs simonbs deleted the enhancement/reduce-rerenderings branch October 22, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant