Adds support for logging in as a guest #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…login # Conflicts: # src/composition.ts
# Conflicts: # __test__/auth/HostAccessTokenService.test.ts # __test__/auth/HostCredentialsTransferrer.test.ts # __test__/projects/CachingProjectDataSource.test.ts # src/common/keyValueStore/index.ts # src/common/mutex/index.ts # src/common/session/Auth0Session.ts # src/common/session/index.ts # src/common/utils/index.ts # src/composition.ts # src/features/auth/data/GitHubOAuthTokenRefresher.ts # src/features/auth/data/index.ts # src/features/auth/domain/accessToken/index.ts # src/features/auth/domain/credentialsTransfer/index.ts # src/features/auth/domain/index.ts # src/features/auth/domain/logIn/index.ts # src/features/auth/domain/logOut/index.ts # src/features/auth/domain/oAuthToken/index.ts # src/features/hooks/domain/index.ts # src/features/projects/data/GitHubProjectDataSource.ts # src/features/projects/data/index.ts # src/features/projects/data/useProjects.ts # src/features/projects/domain/ProjectRepository.ts # src/features/projects/domain/SessionValidatingProjectDataSource.ts # src/features/projects/domain/index.ts
# Conflicts: # src/common/session/index.ts # src/composition.ts
…cs into enhancement/guest-login
ulrikandersen
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guests are invited through the Invite Guest GitHub action and will only have access to the specified repositories.
After inviting a guest they will receive an e-mail asking them to set a password. After doing that they can login with their e-mail and password.
Because guests do not have a personal access token for GitHub, we use the GitHub App to generate an installation token that is only valid for the repositories that the user needs access to. Each installation token is unique to a user and to their set of repositories.
Unfortunately, the PR is huge. There are several reasons for this. For one, adding a new authentication mechanism isn’t trivial but I’ve also refactored some types in an attempt to keep reduce the complexity of our codebase.
Some of these changes have already been extracted into other PRs, namely #125, #126, #127, #128, and #132. I might make an attempt to split up the PR even more but I’m unsure if it’s worth the effort. I think the most important thing is that I onboard at least one of you to the ideas in the codebase so you know how we authenticate guests and can provide feedback where needed.