Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows error if user is not part of the organization #124

Merged
merged 14 commits into from
Nov 6, 2023

Conversation

simonbs
Copy link
Contributor

@simonbs simonbs commented Nov 6, 2023

With the changes in this PR we will present the user with the following page if they have logged in but are not part of our organization.

Screenshot 2023-11-06 at 10 53 17

We check if the user is part of our organization when fetching the repositories from GitHub. We do not perform the check before returning cached data to the user, only when refetching the projects from GitHub. This ensures that the app still feels snappy.

The error will be shown if users login but aren't part of our organizations and when people loose access to our organization.

@simonbs simonbs self-assigned this Nov 6, 2023
@simonbs simonbs removed the request for review from ulrikandersen November 6, 2023 08:54
@simonbs simonbs marked this pull request as draft November 6, 2023 08:55
@simonbs simonbs marked this pull request as ready for review November 6, 2023 10:17
Copy link
Contributor

@ulrikandersen ulrikandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@simonbs simonbs merged commit 3e8cf0a into develop Nov 6, 2023
3 checks passed
@simonbs simonbs deleted the enhancement/validate-github-organization branch November 6, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants