checks for missing soc and ae in complete_ae_data #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddsjoberg
reviewed
Nov 16, 2023
|
ok @ddsjoberg, feedback addressed and checks are passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Added errors and messaging for different types of missing soc & ae in
complete_ae_data, along withcorresponding tests.
If there is an GitHub issue associated with this pull request, please provide link.
closes #204
Checklist for PR reviewer
renv::install()_pkgdown.ymlpkgdown::build_site(). Check the R console for errors, and review the rendered website.covr::report(). Before you run, setSys.setenv(NOT_CRAN="true")and begin in a fresh R session without any packages loaded.usethis::use_spell_check()runs with no spelling errors in documentationNEWS.mdbeen updated with the changes from this pull request under the heading "# gtreg (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).usethis::use_version(which = "dev")