-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: update dtls2 package to version 0.18.0 #200
Conversation
Getting some analysis errors on merge - error: The name 'Certificate' isn't a type, so it can't be used as a type argument. (non_type_as_type_argument at [coap] lib/src/network/coap_network_openssl.dart:61) |
Thank you for merging and your comment! Are you getting these errors locally or in the CI? |
Hi, Locally in my IDE(Intellij) appeared as soon as I merged into master. |
Hmm, that is strange, I cannot reproduce it on my machine, and the CI seems also fine – do you maybe need to rerun |
Ah yes, needed a pub get! I wish it would remind me of this when I pull an updated pubspec.yaml. |
Running example get_resource_secure.dart gives -
Probably just needs an update for the DTLS changes. |
Thank you for pointing that out! I think it is actually related to recent changes in OpenSSL which cause the cipher suite that is defined in the example to only be usable when reducing the "security level". I've already implemented a way to adjust the security level in dtls2, for which I will create a PR here shortly. |
Great thanks. |
#203 should now provide a fix for this issue :) |
This PR updates the
dtls2
package to the latest version. Since there have been API changes indtls2
regarding the handling of certificates, the relevant parts of the API for this package are modified accordingly and the certificate classes in question are re-exported.The main benefit of this change is now that you are able to provide root certificates that can also be in PEM format, making the use of DTLS in PKI mode a bit more versatile and the API itself clearer. However, as there are API changes involved, they have to be considered breaking changes.