Skip to content

Commit

Permalink
fixed comment typo
Browse files Browse the repository at this point in the history
  • Loading branch information
zonyitoo committed May 21, 2022
1 parent 6644b30 commit 809b7d8
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions crates/shadowsocks-service/src/local/net/udp/association.rs
Original file line number Diff line number Diff line change
Expand Up @@ -539,10 +539,12 @@ where
self.client_packet_id = match self.client_packet_id.checked_add(1) {
Some(i) => i,
None => {
// FIXME: client_packet_id overflowed. What's the properly to handle this?
// FIXME: client_packet_id overflowed. What's the proper way to handle this?
//
// Reopen a new session is not a perfect way, because the remote target will receive packets from a different address.
// Reopen a new session is not perfect, because the remote target will receive packets from a different address.
// For most application protocol, like QUIC, it is fine to change client address.
//
// But it will happen only when a client continously send 18446744073709551616 packets without renewing the socket.

let new_session_id = generate_client_session_id();

Expand Down

0 comments on commit 809b7d8

Please sign in to comment.