Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP API #895

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

HTTP API #895

wants to merge 18 commits into from

Conversation

yangziy
Copy link

@yangziy yangziy commented Sep 17, 2018

This PR implements features required in #40 #48 .


Feature

The API enables user to do the following via HTTP.

  • Check current status (on/off)
  • Toggle the client
  • Get server list
  • Add new server
  • Modify server
  • Delete server
  • Get current server
  • Select server
  • Get current mode
  • Switch mode

HTTP API Specification

Copyright

Most code in HTTPUserProxy.swift comes from yichengchen's fork, with slight modification to solve some incompatibility due to obsolete methods.

Refactor in class AppDelegate.
@yangziy
Copy link
Author

yangziy commented Sep 21, 2018

Alfred Workflow

With the API you can control the app by this Alfred workflow.

@yangziy yangziy closed this Sep 21, 2018
@yangziy yangziy reopened this Sep 21, 2018
@yangziy yangziy changed the title HTTP API & AppleScript support. HTTP API Sep 26, 2018
@yangziy
Copy link
Author

yangziy commented Sep 26, 2018

Though available in previous commits, AppleScript support is removed because of its low speed. Since all features provided by AppleScript API are covered in HTTP API, there's no point to maintain such a slow interface.

Modify HTTP API. Update document. Remove AppleScript Support.
Copy link

@ruur ruur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants