-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify string handling #1048
Draft
alejandro-colomar
wants to merge
4
commits into
shadow-maint:master
Choose a base branch
from
alejandro-colomar:string
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Simplify string handling #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
string
branch
3 times, most recently
from
July 11, 2024 09:52
01ff60f
to
812cbae
Compare
alejandro-colomar
force-pushed
the
string
branch
from
July 12, 2024 12:08
812cbae
to
4d80b61
Compare
alejandro-colomar
force-pushed
the
string
branch
from
July 17, 2024 22:23
4d80b61
to
1eb75b3
Compare
alejandro-colomar
force-pushed
the
string
branch
from
July 21, 2024 17:32
1eb75b3
to
a719bc3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
alejandro-colomar
force-pushed
the
string
branch
from
July 30, 2024 16:16
a719bc3
to
ad52f5f
Compare
alejandro-colomar
force-pushed
the
string
branch
from
August 12, 2024 00:30
ad52f5f
to
5b35729
Compare
alejandro-colomar
force-pushed
the
string
branch
3 times, most recently
from
September 1, 2024 13:53
ffdf778
to
afd0b32
Compare
@hallyn would you need me to split this PR into smaller chunks for making it easier for you to review? Or any other change you'd like to see? Maybe strtok=>strsep is a large change, less trivial than the previous ones, and I should split right before the strtok changes. |
Let's queue this after #1085 |
alejandro-colomar
force-pushed
the
string
branch
3 times, most recently
from
October 14, 2024 12:34
be7b302
to
a4838e6
Compare
This was referenced Oct 14, 2024
alejandro-colomar
force-pushed
the
string
branch
from
October 15, 2024 09:21
a4838e6
to
5f396fe
Compare
Signed-off-by: Alejandro Colomar <[email protected]>
This is simpler to read, IMO. Signed-off-by: Alejandro Colomar <[email protected]>
…onals For negative matches, use if (strchr(...) == NULL) For positive matches, use the cast-to-bool operator: if (!!strchr(...)) For positive matches, when a variable is also set, use while (NULL != (p = strchr(...))) Signed-off-by: Alejandro Colomar <[email protected]>
A few lines above, we've removed the '\n' already. Signed-off-by: Alejandro Colomar <[email protected]>
alejandro-colomar
force-pushed
the
string
branch
from
October 15, 2024 10:09
5f396fe
to
aa3f0f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other things, remove most uses of strtok(3). Replace its calls by strsep(3), which is stateless.
This probably silently fixes some bugs, where two separators were being merged as the same one.
Also, that's the reason why I didn't replace all strtok(3) calls. In some cases (paths), it makes sense to merge adjacent
//
.Revisions:
v1b
v1c
v1d
v2
v2b
v2c
v2d
v2e
v3
v3b
v3c
v3d
v3e