Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to exclude webgpu-dawn and slang-tint #6537

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

jarcherNV
Copy link
Contributor

Add option to exclude webgpu-dawn and slang-tint from the build, for environments that need to build Slang without internet access.

@jarcherNV jarcherNV requested a review from a team as a code owner March 7, 2025 07:14
jkwak-work
jkwak-work previously approved these changes Mar 7, 2025
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@aleino-nv may want to take a look?

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Mar 7, 2025
@aleino-nv
Copy link
Collaborator

aleino-nv commented Mar 7, 2025

Can it be two separate options?

We have separate usages of Tint (file check tests) and Dawn (tests that use WebGPU).

Add option to exclude webgpu-dawn and slang-tint from the build,
for environments that need to build Slang without internet access.
@jarcherNV
Copy link
Contributor Author

Second revision splits this into 2 separate options as suggested by aleino.

@jarcherNV jarcherNV enabled auto-merge (squash) March 7, 2025 16:23
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good enough.

But the naming pattern we have is SLANG_USE_SYSTRM_XXX, isn't it?

@jarcherNV jarcherNV merged commit 5012c31 into shader-slang:master Mar 7, 2025
16 checks passed
@jarcherNV jarcherNV deleted the jarcher-dev branch March 7, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants