Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build to allow setting external paths #6528

Merged
merged 6 commits into from
Mar 7, 2025

Conversation

jarcherNV
Copy link
Contributor

Update the build to allow setting user-specific paths for the external modules. This allows building Slang without also fetching the external modules, assuming they are already present elsewhere locally.

@jarcherNV jarcherNV requested a review from a team as a code owner March 5, 2025 20:22
@CLAassistant
Copy link

CLAassistant commented Mar 5, 2025

CLA assistant check
All committers have signed the CLA.

Update the build to allow setting user-specific paths for the external modules.
This allows building Slang without also fetching the external modules, assuming
they are already present elsewhere locally.
@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Mar 6, 2025
jkwak-work
jkwak-work previously approved these changes Mar 6, 2025
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jkwak-work
Copy link
Collaborator

/format

@slangbot
Copy link
Contributor

slangbot commented Mar 6, 2025

🌈 Formatted, please merge the changes from this PR

Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving after merging with ToT

@jarcherNV jarcherNV merged commit 9d7d943 into shader-slang:master Mar 7, 2025
16 checks passed
@jarcherNV jarcherNV deleted the jarcher-dev branch March 7, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants