Fix a bug in default ctor synthesizing #6527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is fix for the implementation bug, when a struct has explict ctor we should not synthesize the default ctor anymore.
A struct could has no synthesized ctor when it inherits from a base struct that has explicit ctor, in this case, we should check whether this is a c-style struct and report error when it's assigned by initializer list.
kaizhangNV
force-pushed
the
default-ctor-fix
branch
from
efcae67 to
ca4a6a7
Compare
kaizhangNV
force-pushed
the
default-ctor-fix
branch
from
83c7473 to
83ef0cd
Compare
csyonghe
approved these changes
Mar 6, 2025
csyonghe
reviewed
Mar 7, 2025
| // more proper solution for array initialization, so if the right hand side is an array | ||
| // type, we will not report error and fall-back to legacy initializer list logic. | ||
| bool isArrayType = as<ArrayExpressionType>(toType) != nullptr; | ||
| if (!isCStyle && !isArrayType) |
There was a problem hiding this comment.
I think the ordering of steps that needs to happen is:
Try match to a ctor call, if succeeded done.
If array type and empty init list, try construct a single value of the element type with empty init list, if succeed, create a MakeArrayFromSingleValue(singleValue) node for the array value, done.
If that failed, fallback to cstyle logic if applicable.
If that failed, error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for the implementation bug, when a struct has explict ctor we should not synthesize the default ctor anymore.