Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module organization suggestion doc #6509

Merged
merged 9 commits into from
Mar 5, 2025

Conversation

cheneym2
Copy link
Collaborator

@cheneym2 cheneym2 commented Mar 3, 2025

Suggest one method to keep slang modules organized in the file system.

Closes #4841

Suggest one method to keep slang modules organized in the file system.

Closes shader-slang#4841
@cheneym2 cheneym2 requested a review from a team as a code owner March 3, 2025 17:46
jkwak-work
jkwak-work previously approved these changes Mar 3, 2025
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cheneym2 cheneym2 enabled auto-merge (squash) March 3, 2025 18:45

### Module Organization Suggestions

- Top-level modules are those that are `import`ed by user code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terminology isn't very accurate: the util.slang is the "main module file", and files being __included are just files in that module. They are not "submodules".

Think about a module as a Visual Studio C++/C# Project, and a file is just a file in that project.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if I missed any inaccuracies.

@cheneym2 cheneym2 force-pushed the cheneym2/moduledocs branch from cc0cdd9 to 99f8e40 Compare March 3, 2025 19:31
@cheneym2 cheneym2 merged commit 965f962 into shader-slang:master Mar 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix and update docs and examples for slang modules
3 participants