Implement floating-point pack/unpack intrinsics for all targets #6503
+776
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
previously approved these changes
Mar 2, 2025
| @@ -1076,6 +1076,9 @@ Compound Capabilities | |||
| `shader5_sm_5_0` | |||
| > Capabilities required to use sm_5_0 features apart of GL_ARB_gpu_shader5 | |||
|
|
|||
| `pack_unpack` | |||
There was a problem hiding this comment.
Suggest naming it to “pack_float” instead.
There was a problem hiding this comment.
This capability is also used for integer pack/unpack intrinsics. The main reason this cap is added is to combine GL_ARB_gpu_shader5 with sm 6.6(which introduces HLSL integer pack/unpack intrinsics). I can change this to pack if that is still better than pack_unpack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6175.
Adds floating-point pack/unpack intrinsics for all targets. Some of the implementation code is taken from the already implemented GLSL variants but a lot of the logic for unsupported targets are incorrect and there were no functional tests
to verify them. This PR fixes them and adds full test suites for all targets.
Additionally fixes the SM 6.6 requirement for HLSL integer pack/unpack intrinsics.