Enable D3D12 experimental feature to use coopvec #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
|
A lot of dx12 tests are failing; if not all. |
csyonghe
reviewed
Feb 5, 2025
| @@ -13,6 +13,10 @@ | |||
| #include "slang-support.h" | |||
| #include "window.h" | |||
|
|
|||
| #if defined(_WIN32) | |||
There was a problem hiding this comment.
Why is this include needed?
There was a problem hiding this comment.
It is needed for the type UUID.
jkwak-work
force-pushed
the
feature/support_dxc_experimental_shader_model_6_8
branch
from
1d13f0d to
2701f39
Compare
auto-merge was automatically disabled
February 5, 2025 23:14
Pull request was converted to draft
jkwak-work
force-pushed
the
feature/support_dxc_experimental_shader_model_6_8
branch
from
2701f39 to
6b3dd20
Compare
jkwak-work
force-pushed
the
feature/support_dxc_experimental_shader_model_6_8
branch
from
6b3dd20 to
5134c90
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
|
In order to use CoopVec feature with dxcompiler.dll, Gfx had to enable "d312 experimental feature". |
csyonghe
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6279
This commit enables "D3D12-experimenta-feature" in render-test.
This is required to use CoopVec feature with dxcompiler.dll.
But it is enabled only when "-dx12-experimental" is used, because it appears that DX12 becomes unstable when the experimental feature is enabled, which causes bunch of tests randomly failing.