Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raypayload decoration to ray payload structs #6164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add raypayload decoration to ray payload structs #6164

wants to merge 2 commits into from

Conversation

expipiplus1
Copy link
Collaborator

Closes #6104

@expipiplus1 expipiplus1 requested a review from a team as a code owner January 23, 2025 12:05
@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Jan 24, 2025
jkwak-work
jkwak-work previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

As a part of this PR, I think you should remove the following lines from tests/expected-failure*.txt

gfx-unit-test-tool/RayTracingTestAD3D12.internal
gfx-unit-test-tool/RayTracingTestBD3D12.internal

@expipiplus1 expipiplus1 force-pushed the push-tsvqppwtvtmu branch 2 times, most recently from 55939db to eb5bad2 Compare January 24, 2025 11:54
@jkwak-work
Copy link
Collaborator

It looks like those tests are still failing,

===
99% of tests passed (4417/4419), 1061 tests ignored
===

failing tests:
---
gfx-unit-test-tool/RayTracingTestBD3D12.internal
gfx-unit-test-tool/RayTracingTestAD3D12.internal
---
Error: Process completed with exit code 1.

https://github.com/shader-slang/slang/actions/runs/12949110795/job/36270706353?pr=6164

@expipiplus1 expipiplus1 force-pushed the push-tsvqppwtvtmu branch 2 times, most recently from 24c6116 to 6d65305 Compare February 3, 2025 13:59
@expipiplus1 expipiplus1 mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwak-work jkwak-work jkwak-work left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest DXC requires a new keyword [raypayload] on a struct when used as ray-tracing payload
2 participants
@expipiplus1 @jkwak-work